fix: record PR 443 review follow-ups#448
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
|
Updates to Preview Branch (codex/pr443-review-followups) ↗︎
Tasks are run on every commit but only new migration files are pushed.
❌ Branch Error • Thu, 09 Jul 2026 12:45:27 UTC View logs for this Workflow Run ↗︎. |
BigSimmo
added a commit
that referenced
this pull request
Jul 9, 2026
* feat: add image generation metadata re-stamp script * chore: reconcile ingestion RPC execute privileges, schema.sql and drift manifest * ci: add db-reset-verify and dependency-review workflows * ci: remove dependency-review workflow because repository is private without GHAS * 📝 CodeRabbit Chat: Simplify code implementation (#434) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix(db): rename duplicate migration version 20260708160000 to unique 20260708160001 * fix: run prettier on 19 files to fix CI format:check failure (#436) * fix: address PR 433 review comments - Defer embedding until after text/document fast paths and coverage gate - Rehydrate cached document metadata in attachDocumentRankingMetadata - Load env-dependent script imports after loadEnvConfig in seed/reindex scripts - Harden registry corpus: shared identity, medication tags, rollback, detail hrefs - Route registry citations to detail pages; handle registry rows in signed-url API - Prioritize safety warnings over registry info; preserve stale registry labels - Guard OCR repair against dropping isolated single-letter clinical tokens - Update skill docs, changelog dedup, CI Supabase setup-cli@v3 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: address follow-up PR 433 review comments - Backfill NULL document_images.index_generation_id during re-stamp - Count globally forced embedding eval cases in retrieval summaries Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: address PR 433 review blockers * fix: address PR 433 review comments on image re-stamp and eval forcing Treat NULL document_images.index_generation_id as stale even when JSON metadata already matches the committed generation, and propagate global --force-embedding into eval reporting/validation so index-unit-vector runs count forced cases correctly. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: restore neutralized 160000 migration for Supabase Preview parity PR #433 preview branch recorded 20260708160000 before the file was removed, causing remote migration versions not found in local migrations directory. Keep a no-op stub for history sync; transactional index DDL stays on 170000. Co-authored-by: Cursor <cursoragent@cursor.com> * ci: keep supabase cache save non-blocking * ci: run migration verification before docker image cache save * fix: address registry corpus review comments * Finish RAG registry re-embed and quality routing (#438) * fix(rag): finish registry re-embed and quality routing * fix: resolve merge conflicts with claude/llm-pipeline-review --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> * docs: codify review and branch cleanup workflow * merge: resolve conflicts with main — keep registry re-embed hooks and list-owners feature, adopt registry route metadata fields from main * fix: apply prettier formatting to fix CI format:check failure * Update src/lib/rag-extractive-answer.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/lib/rag-extractive-answer.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: remove spurious closing braces in rag-extractive-answer.ts * Fix PR 443 review findings and restore CI verify gate. Resolve rag-extractive-answer parse errors, tighten clozapine blood-withhold routing guards, scope live-drift secrets to required steps, restore answer-generation SDK retries, add docstrings for governance coverage, and document the exact retrieval eval command used post-registry embed. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: resolve merge conflicts with origin/main * fix: address code review findings from merge conflict resolution * fix: record PR 443 review follow-ups (#448) * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix: format docs/branch-review-ledger.md to pass Prettier check --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
These were left as dirty local follow-ups for
claude/llm-pipeline-review; this PR packages them separately against the PR #443 branch instead of mixing them into unrelated work.Verification
git diff --check HEAD^ HEADpassed.npm run check:type-scaleexited 0; it still reports existing arbitrary font-size utilities outside this small follow-up.Checks not run
npm run verify:cheapwas not run in this checkout becausenode_modulesis not installed locally andtsxis unavailable without install.Risk
generated_at/replay_seconds) because the schema hash was already current on the PR RAG routing hardening, registry corpus embedding, and review docs #443 branch.